-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency ws to v8 [security] #3371
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 418280e The changes in this PR will be included in the next version bump. This PR includes changesets to release 140 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
August 6, 2024 13:47
449737d
to
4d8959c
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
August 6, 2024 16:06
4d8959c
to
8b1619a
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
August 6, 2024 17:23
8b1619a
to
a35753e
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
August 7, 2024 14:23
a35753e
to
47640f5
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
August 8, 2024 00:35
47640f5
to
61241ca
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
August 8, 2024 12:33
61241ca
to
f18adcf
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
August 9, 2024 13:06
f18adcf
to
da16b2b
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
August 9, 2024 18:26
da16b2b
to
0766ea5
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
August 9, 2024 19:53
0766ea5
to
92a594c
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
August 12, 2024 16:50
92a594c
to
be01e14
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
August 14, 2024 22:57
be01e14
to
a4929ba
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
August 15, 2024 03:53
a4929ba
to
aa385f4
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
August 15, 2024 07:02
aa385f4
to
d354d20
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
August 17, 2024 01:03
d354d20
to
36bfbb0
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
October 11, 2024 13:13
3f863d8
to
31822b4
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
October 11, 2024 14:14
31822b4
to
f264a4c
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
October 11, 2024 19:09
f264a4c
to
091006a
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
October 14, 2024 22:02
091006a
to
69d81e7
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
October 15, 2024 14:38
69d81e7
to
d1249a8
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
October 15, 2024 15:30
d1249a8
to
c86b621
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
October 15, 2024 15:57
c86b621
to
151b893
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
October 15, 2024 16:51
151b893
to
7ecfd7d
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
October 15, 2024 20:53
7ecfd7d
to
01516f3
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
October 16, 2024 01:00
01516f3
to
b6bbea9
Compare
renovate
bot
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
October 16, 2024 11:18
b6bbea9
to
eda6807
Compare
mxiao-cll
force-pushed
the
renovate/npm-ws-vulnerability
branch
from
October 16, 2024 13:21
eda6807
to
418280e
Compare
mxiao-cll
approved these changes
Oct 16, 2024
stibala
pushed a commit
to m0-foundation/external-adapters-js
that referenced
this pull request
Oct 24, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^7.4.6
->^8.0.0
^7.4.4
->^8.0.0
GitHub Vulnerability Alerts
CVE-2021-32640
Impact
A specially crafted value of the
Sec-Websocket-Protocol
header can be used to significantly slow down a ws server.Proof of concept
Patches
The vulnerability was fixed in ws@7.4.6 (websockets/ws@00c425e) and backported to ws@6.2.2 (websockets/ws@78c676d) and ws@5.2.3 (websockets/ws@76d47c1).
Workarounds
In vulnerable versions of ws, the issue can be mitigated by reducing the maximum allowed length of the request headers using the
--max-http-header-size=size
and/or themaxHeaderSize
options.Credits
The vulnerability was responsibly disclosed along with a fix in private by Robert McLaughlin from University of California, Santa Barbara.
CVE-2024-37890
Impact
A request with a number of headers exceeding the
server.maxHeadersCount
threshold could be used to crash a ws server.Proof of concept
Patches
The vulnerability was fixed in ws@8.17.1 (websockets/ws@e55e510) and backported to ws@7.5.10 (websockets/ws@22c2876), ws@6.2.3 (websockets/ws@eeb76d3), and ws@5.2.4 (websockets/ws@4abd8f6)
Workarounds
In vulnerable versions of ws, the issue can be mitigated in the following ways:
--max-http-header-size=size
and/or themaxHeaderSize
options so that no more headers than theserver.maxHeadersCount
limit can be sent.server.maxHeadersCount
to0
so that no limit is applied.Credits
The vulnerability was reported by Ryan LaPointe in https://github.com/websockets/ws/issues/2230.
References
Release Notes
websockets/ws (ws)
v8.17.1
Compare Source
Bug fixes
A request with a number of headers exceeding the[
server.maxHeadersCount
][server.maxHeadersCount]threshold could be used to crash a ws server.
The vulnerability was reported by Ryan LaPointe in https://github.com/websockets/ws/issues/2230.
In vulnerable versions of ws, the issue can be mitigated in the following ways:
[
--max-http-header-size=size
][--max-http-header-size=size] and/or the [maxHeaderSize
][maxHeaderSize] options sothat no more headers than the
server.maxHeadersCount
limit can be sent.server.maxHeadersCount
to0
so that no limit is applied.v8.17.0
Compare Source
Features
WebSocket
constructor now accepts thecreateConnection
option (#2219).Other notable changes
allowSynchronousEvents
option has been changed totrue
(#2221).This is a breaking change in a patch release. The assumption is that the option
is not widely used.
v8.16.0
Compare Source
Features
autoPong
option (01ba54e
).v8.15.1
Compare Source
Notable changes
allowMultipleEventsPerMicrotask
option has been renamed toallowSynchronousEvents
(4ed7fe5
).This is a breaking change in a patch release that could have been avoided with
an alias, but the renamed option was added only 3 days ago, so hopefully it
hasn't already been widely used.
v8.15.0
Compare Source
Features
allowMultipleEventsPerMicrotask
option (93e3552
).v8.14.2
Compare Source
Bug fixes
swallowed when running tests (
7f4e1a7
).v8.14.1
Compare Source
Bug fixes
fd3c64c
).v8.14.0
Compare Source
Features
WebSocket
constructor now accepts HTTP(S) URLs (#2162).socket
argument ofserver.handleUpgrade()
can now be a genericDuplex
stream (#2165).Other notable changes
v8.13.0
Compare Source
Features
finishRequest
option to support late addition of headers (#2123).v8.12.1
Compare Source
Bug fixes
browser
condition to package.json (#2118).v8.12.0
Compare Source
Features
utf-8-validate@6
(ff63bba
).Other notable changes
buffer.isUtf8()
][buffer.isUtf8()] is now used instead ofutf-8-validate
if available(
42d79f6
).v8.11.0
Compare Source
Features
WebSocket.prototype.addEventListener()
now supports an event listenerspecified as an object with a
handleEvent()
method. (9ab743a
).Bug fixes
WebSocket.prototype.addEventListener()
now adds an event listener only if itis not already in the list of the event listeners for the specified event type
(
1cec17d
).v8.10.0
Compare Source
Features
211d5d3
).v8.9.0
Compare Source
Features
v8.8.1
Compare Source
Bug fixes
Authorization
andCookie
headers are no longer sent if the originalrequest for the opening handshake is sent to an IPC server and the client is
redirected to another IPC server (
bc8bd34
).v8.8.0
Compare Source
Features
WS_NO_BUFFER_UTIL
andWS_NO_UTF_8_VALIDATE
environmentvariables (
becf237
).v8.7.0
Compare Source
Features
them with a custom HTTP response. (
6e5a5ce
).Bug fixes
Upgrade
header field value in the HTTPresponse is not a case-insensitive match for the value "websocket" (
0fdcc0a
).Authorization
andCookie
headers are no longer sent when following aninsecure redirect (wss: to ws:) to the same host (
d68ba9e
).v8.6.0
Compare Source
Features
v8.5.0
Compare Source
Features
WebSocket
class on the server (#2007).Bug fixes
Authorization
andCookie
headers are nolonger sent if the redirect host is different from the original host (#2013).
v8.4.2
Compare Source
Bug fixes
v8.4.1
Compare Source
Notable changes
websocket.ping()
,websocket.pong()
, andwebsocket.send()
are no longer converted toBuffer
s if the data does not need to be masked (#2000).v8.4.0
Compare Source
Features
v8.3.0
Compare Source
Features
WebSocket
(0a8c7a9
).Bug fixes
using the stream API (
ed2b803
).redirect URL is invalid (#1980).
v8.2.3
Compare Source
Bug fixes
is below the value of the
perMessageDeflate.threshold
option (41ae563
).v8.2.2
Compare Source
Bug fixes
ec9377c
).v8.2.1
Compare Source
Bug fixes
from being closed cleanly (
869c989
).v8.2.0
Compare Source
Features
WebSocket.WebSocket
as an alias forWebSocket
andWebSocket.WebSocketServer
as an alias forWebSocket.Server
to fix nameconsistency and improve interoperability with the ES module wrapper (#1935).
v8.1.0
Compare Source
Features
Bug fixes
6a72da3
).c95e695
).v8.0.0
Compare Source
Breaking changes
The
WebSocket
constructor now throws aSyntaxError
if any of thesubprotocol names are invalid or duplicated (
0aecf0c
).The server now aborts the opening handshake if an invalid
Sec-WebSocket-Protocol
header field value is received (1877dde
).The
protocols
argument ofhandleProtocols
hook is no longer anArray
buta
Set
(1877dde
).The opening handshake is now aborted if the
Sec-WebSocket-Extensions
headerfield value is empty or it begins or ends with a white space (
e814110
).Dropped support for Node.js < 10.0.0 (
552b506
).The
WebSocket
constructor now throws aSyntaxError
if the connection URLcontains a fragment identifier or if the URL's protocol is not one of
'ws:'
,'wss:'
, or'ws+unix:'
(ebea038
).Text messages and close reasons are no longer decoded to strings. They are
passed as
Buffer
s to the listeners of their respective events. The listenersof the
'message'
event now take a boolean argument specifying whether or notthe message is binary (
e173423
).Existing code can be migrated by decoding the buffer explicitly.
The package now uses an ES module wrapper (
78adf5f
).WebSocketServer.prototype.close()
no longer closes existing connections(
df7de57
).Existing code can be migrated by closing the connections manually.
The callback of
WebSocketServer.prototype.close()
is now called with anerror if the server is already closed (
abde9cf
).WebSocket.prototype.addEventListener()
is now a noop if thetype
argumentis not one of
'close'
,'error'
,'message'
, or'open'
(9558ed1
).WebSocket.prototype.removeEventListener()
now only removes listeners addedwith
WebSocket.prototype.addEventListener()
and only one at time (ea95d9c
).The value of the
onclose
,onerror
,onmessage
, andonopen
properties isnow
null
if the respective event handler is not set (6756cf5
).The
OpenEvent
class has been removed (21e6500
).Bug fixes
event listeners added with
WebSocket.prototype.addEventListener()
(
0b21c03
).v7.5.10
Compare Source
Bug fixes
e55e510
to the 7.x release line (22c2876
).Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.